jetty/jetty.project

Review RolloverFileOutputStream locking

開放

#5,092 建立於 2020年7月29日

 (6 則留言) (0 個反應) (0 位負責人)Java (1,913 個分叉)batch import
Help WantedLow PriorityPinned

倉庫指標

星標
 (3,701 顆星)
PR 合併指標
 (平均合併 6天 14小時) (30 天內合併 48 個 PR)

描述

Spawned by #5083.

Jetty version 9.4.x

Description RolloverFileOutputStream locking should be improved/removed.

Currently it locks on a class lock for no reasons, since __rollover is only ever written in the constructor (and thus could be final).

There should be some synchronization between the writes and the scheduled task (so that the file can be swapped without losing log lines), but the class locks seem unnecessary.

貢獻者指南