Cleanup SpotBugs warnings in the codebase · jenkinsci/jenkinsfile-runner#374

(0 留言) (0 反應) (0 負責人)Java (1,090 star) (291 fork)batch import

good first issueinternal

描述

There is a number of SporBugs static analysis warnings in the old parts of the Jenkinsfile Runner codebase. It is possible to see the warnings in the build log. Although there is no severe issues, it would be great to cleanup these warnings and then enforce SpotBugs checks during the build.

List of the current SpotBugs violations: https://ci.jenkins.io/job/jenkinsfile-runner/job/jenkinsfile-runner/job/master/lastSuccessfulBuild/analysis/

Acceptance criteria:

All SpotBugs violations need to be either fixed or suppressed
FindBugs failOnError is reenabled in the pom.xml

NOTE: Contributors can submit pull requests for particular issues and issue types, no need to fix everything in a single pull request.

貢獻者指南

技術棧: java
領域: backendbuild system
議題類型: refactor
難度: 3
預計時間: 3-5 days
活動狀態: stale
清晰度: mostly clear
前置要求: JavaMavenSpotBugs
新手友善度: 50
研究方向: Examine the SpotBugs violations list at the provided URL (https://ci.jenkins.io/job/jenkinsfile runner/job/jenkinsfile runner/job/master/lastSuccessfulBuild/analysis/). For each violation, decide whether to fix the code or suppress the warning with justification. After addressing violations, reenable failOnError in pom.xml. Contributors can focus on specific violation types or areas.