jazzband/django-taggit

Enhacement: Add remove_by_slug() method to TaggableManager

Open

#151 建立於 2013年8月23日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Python (3,433 star) (624 fork)user submission
enhancementgood first issue

描述

That way it would also be possible to remove tags by providing their unique slugs. Have in mind that people might want to use URLs like .../some-object/tags/my-precious-tag/remove/ to remove a tag.

Adding this method seems easy, but I am reluctant to contribute a PR because I am not sure if I can write correct tests for this code addition. If some guidance and supervision is provided I am willing to try.

貢獻者指南

技術棧
pythondjango
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PythonDjangodjango taggitDjango testing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
The proposed method `remove by slug()` should be added to `TaggableManager` in `taggit/managers.py`. The existing `remove()` method can serve as a reference. Tests should be added in `taggit/tests.py` following patterns of existing test methods. The author expressed uncertainty about tests, so reviewing test structure and asking for maintainer clarification on expected behavior might be necessary.
Enhacement: Add remove_by_slug() method to TaggableManager · jazzband/django-taggit#151 | Good First Issue