jazzband/django-silk

Profiles don't seem to be created

Open

#215 建立於 2017年10月4日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Python (3,958 star) (319 fork)batch import
help wanted

描述

Using the latest master version, there seems to me that the only way to get profiling is to decorate a method/function with the silk_profile decorator.

The only place where Profile objects are created is here, and it happens for every profile object given by the DataCollector.profiles method. Now those profile objects are only registered using the register_profile in the _finalise_queries method which is part of the silk_profile decorator. From what I found, the decorator is only used for dynamic profiling throughout the project.

Note that the .prof files are being generated correctly.

Am I doing something wrong here?

貢獻者指南

技術棧
python
領域
backendperformance
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Django request lifecyclePython decoratorsSilk's profiling pipeline
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the middleware's profiling logic in silk/middleware.py to understand how requests are automatically profiled. Compare with the manual decorator path in silk/profiling/profiler.py. Determine why Profile objects are only created during the decorator's finalise queries method and not during normal request processing. Check if the DataCollector.profiles method is being called in the automatic path and if so, why Profiler objects are not registered.