jazzband/django-silk

Saving to Request.prof_file raises DataError for paths longer than 251 characters

Open

#201 建立於 2017年7月31日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Python (3,958 star) (319 fork)batch import
help wanted

描述

The decorator is raising a DataError when it tries to store the path of a .prof for any path greater than 251 characters, since the Request.prof_file is 100 300 characters by default, and the filename itself is 41 or 49 characters.

django.db.utils.DataError: value too long for type character varying(300)

In my case, the project path for local development was more than 60 characters at a time the column was 100 chars, which meant the file was saving to disk, but no profile data was being saved to the database. We probably want to at least save the other profile data and log an error, otherwise a long file path breaks profiling altogether.

貢獻者指南

技術棧
pythondjango
領域
backenddatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Django modelsdatabase error handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue occurs in django silk when saving a .prof file path longer than 251 characters. The fix likely involves either truncating the path, increasing the column size, or catching the DataError to save other profile data and log the error. Examine the model definition in silk/models.py and the relevant saving logic in silk/request.py or similar. Consider adding validation in the Request model or the decorator to handle long paths gracefully.