jazzband/django-silk

SQL queries not ordered correctly w/ MySQL as db backend

Open

#130 建立於 2016年7月19日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Python (3,958 star) (319 fork)batch import
enhancementhelp wanted

描述

In https://github.com/django-silk/silk/blob/master/silk/views/sql.py#L23 the queries are ordered by start_time, which on mysql is defined as start_time datetime DEFAULT NULL.

Datetime without further specification has no microsecond precision in MySQL. As a result, the queries do not order correctly.

In our fork, I implemented a quick hack to address this by using the auto incrementing primary key for ordering.

I'm not sure what the level of MySQL support is and if this sort of change is a good idea for other platforms. Therefore not opening a PR, just opening this issue to track the bug.

貢獻者指南

技術棧
pythonsqlmysql
領域
backenddatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Django ORMMySQL datetime precision
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the suggested fix from the fork (commit 9855ac2a0e5b27f3f277e94cf5e8fb49e7b50965) which uses the primary key for ordering. Ensure the change does not break other database backends (e.g., PostgreSQL, SQLite) that support microsecond precision. The file to modify is silk/views/sql.py. Consider if a more robust solution like using datetime with microsecond support or ordering by a combination of fields is needed.