jaredpalmer/formik

Use React.forwardRef in <Formik>

Open

#2,208 建立於 2020年1月14日

在 GitHub 查看
 (14 留言) (4 反應) (0 負責人)TypeScript (34,255 star) (2,801 fork)batch import
Component: FormikFocus: TypeScripthelp wanted

描述

As of 2.1.2, <Formik> now allows for an innerRef prop. However, we should instead use React.forwardRef + React.useImperativeHandle. This is more intuitive and closer to best practices. The problem though, is that <Formik> takes TypeScript generics for Values and I'm not sure how to express this in with forwardRef. AFAICT, you can't because forwardRef returns a constant and constants can't have generics.

Help?!?!

貢獻者指南

技術棧
reacttypescript
領域
frontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactTypeScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
This issue requests converting the <Formik> component to use React.forwardRef. The main challenge is handling TypeScript generics for the Values type parameter. The relevant file is likely src/Formik.tsx. The maintainer should clarify how to type forwardRef with generic props, possibly using React.ForwardRefRenderFunction<HTMLDivElement, FormikProps<Values>>.