jaredpalmer/formik

setFieldError does not prevent handleSubmit

Open

#1,111 建立於 2018年11月15日

在 GitHub 查看
 (10 留言) (3 反應) (0 負責人)TypeScript (34,255 star) (2,801 fork)batch import
Priority: MediumType: Bughelp wantedpinned

描述

🐛 Bug report

This looks like it may be a possible regression on #317, as I can replicate it in the exact same way.

Current Behavior

After setting an error using setFieldError, the handleSubmit function is successfully fired.

Expected behavior

The form should not submit successfully, as there is an error.

Reproducible example

Click "Set Error". You will then be able to successfully submit. https://codesandbox.io/s/43owlv689

Suggested solution(s)

Your environment

Software Version(s)
Formik 1.3.2
React 16.4.2
TypeScript
Browser Chrome
npm/Yarn 6.1.0
Operating System OSX

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic understanding of ReactFamiliarity with Formik
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The bug is that `setFieldError` does not prevent form submission. Look at the linked PR #317 which introduced `setFieldError` and investigate how `handleSubmit` interacts with error state. The reproducible example in the issue (CodeSandbox) can be used to trace the issue. Check the current Formik source code, especially the `handleSubmit` and `validateField` functions, to understand the expected behavior. Consider adding a check for errors before calling `onSubmit`.