jaredpalmer/after.js

Razzle as dev dependency?

開放

#419 建立於 2021年1月10日

 (5 則留言) (4 個反應) (0 位負責人)TypeScript (195 個分叉)github user discovery
after.jsgood first issue

倉庫指標

星標
 (4,090 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

🚀 Feature request

All Razzle examples use Razzle package as dev dependency. Except AfterJS - it needs Razzle as regular dependency because of razzle-dev-utils.

Current Behavior

If Razzle stays as a dev dep, I get this error message in production build:

Error: Cannot find module 'razzle-dev-utils/logger'
 Require stack:
 -  /app/node_modules/@jaredpalmer/after/build/cjs/getAssets.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/render.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/index.js

Desired Behavior

I would like to add AfterJS to my Razzle based project without moving Razzle from dev to regular dependencies.

Suggested Solution

Is using razzle-dev-utils in AfterJS worth? Can it be replaced with something?

貢獻者指南