jakearchibald/svgomg

Revisit `setTimeout` usage/JS animations

Open

#332 建立於 2021年9月29日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (5,473 star) (474 fork)batch import
enhancementhelp wanted

描述

There are known performance issues with setTimeout. IIRC requestAnimationFrame should behave better.

I notice junky settings checkboxes animation on Firefox for Android when Power Saving is enabled on the device. Not sure it's related, but it would probably be better to use rAF anyway?

EDIT: we are also using offsetLeft is ripple. Not sure if there's a better way to do the same thing nowadays.

貢獻者指南

技術棧
javascriptcss
領域
frontendperformance
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic JavaScriptunderstanding of requestAnimationFrame
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Search the codebase for all uses of setTimeout, especially in animation related code. Replace them with requestAnimationFrame to improve performance. Additionally, review the ripple effect implementation that uses offsetLeft and consider modern alternatives like getBoundingClientRect or CSS transforms. The issue does not specify files, so start by examining JavaScript files handling animations or UI interactions.