Enable more revive linter rules · jaegertracing/jaeger#5506

(25 留言) (0 反應) (0 負責人)Go (18,974 star) (2,326 fork)batch import

good first issuehelp wanted

描述

In #5505 we introduced a revive linter, but had to disable many of its rules because they were breaking on some places in the code. https://github.com/jaegertracing/jaeger/blob/b38d2f9bc18806b6e716f6f666a786f0aca7d912/.golangci.yml#L154

We can re-enable those rules incrementally by fixing the corresponding breaks one rule at a time (make lint should succeed) and removing the disabling entry from the config.

Strong advice: DO NOT OPEN A PR without discussing the impact of the specific linter on this issue first. We don't want very possible linter - some of them are stupid, others require a lot of code changes with minimal benefits.

貢獻者指南

技術棧: go
領域: build systemci cddeveloper experience
議題類型: chore
難度: 3
預計時間: over 1 week
活動狀態: active
清晰度: mostly clear
前置要求: Go programmingfamiliarity with revive linterunderstanding of Jaeger codebase
新手友善度: 60
研究方向: Start by examining the disabled revive linter rules in the .golangci.yml file (line 154). Choose one rule, understand why it fails by running `make lint`, and propose a fix in the issue discussion. After maintainer approval, implement the fix and update the config to re enable the rule.