ipfs/kubo

MFS remote pinning policy: log ERROR if pin failed

Open

#7,917 建立於 2021年2月16日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Go (2,725 fork)batch import
P2effort/hoursexp/intermediategood first issuehelp wantedkind/enhancementstatus/readytopic/pinning

倉庫指標

Star
 (13,906 star)
PR 合併指標
 (平均合併 4天 2小時) (30 天內合併 28 個 PR)

描述

go-ipfs 0.8.0-rc2 dispatches remote pin request but does not act on its status, so without manual inspection it is possible to miss the fact that MFS pinning (Pinning.RemoteServices.*.Policies.MFS, #7913) stopped working.

I believe we should keep checking pin status every RepinInterval until its pinned or failed, and if it's the latter, print ERROR into remotepinning/mfs logger. Pinning may fail for multiple reasons, main ones is some arbitrary timeout to find a provider for the data, another one is when you try to pin DAG bigger than allowed quota.

By printing error on MFS pin failure, node operator will be able to notice that remote pinning stopped working due to one of mentioned reasons.

cc #7559 @aschmahmann does this sound sensible?

貢獻者指南