ipfs/kubo

Audit CoreAPI for cases where the context should be canceled internally

Open

#7,200 建立於 2020年4月23日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Go (13,906 star) (2,725 fork)batch import
P3exp/intermediatehelp wantedkind/bug

描述

Version information:

v0.5.0-rc3

Description:

There are several places in the CoreAPI (e.g., Ls) where we're assuming the context will be canceled when the caller is done. If that doesn't happen, we won't cleanup some resources.

Luckily, we are canceling these contexts. However, we shouldn't require that.

貢獻者指南

技術棧
go
領域
backendapiperformance
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with Go's context packageUnderstanding of IPFS CoreAPI
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Audit CoreAPI functions like Ls to find places where resources are cleaned up only when the caller cancels the context. These functions should cancel their own contexts internally to ensure cleanup. Check existing comments and the codebase for patterns. No linked PRs, but the issue is clear about the goal.