ipfs/kubo

unix domain socket not removed if it exists

Open

#6,856 建立於 2020年1月31日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Go (13,906 star) (2,725 fork)batch import
help wantedkind/enhancementtopic/rpc-api

描述

When using a unix domain socket, config: "API": [ "/ip4/127.0.0.1/tcp/5001", "/unix/var/db/ipfs-go/socket/api.sock" ],

the first time it starts up, it works fine, but the second time it fails:

Error: serveHTTPApi: manet.Listen(/unix/var/db/ipfs-go/socket/api.sock) failed: listen unix /var/db/ipfs-go/socket/api.sock: bind: address already in use

It is common for programs to either use a lock file, or just simply remove it on start.

I've worked around the issue by removing it in my startup file, but a better solution that is more generic would be nice.

貢獻者指南

技術棧
go
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programming languageBasic understanding of Unix domain sockets
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Investigate the HTTP API server initialization in the repository, specifically the function that creates the listener for Unix sockets. The issue requires that before listening on a Unix socket, the program should check if the socket file already exists and remove it. Look at the code in `cmd/ipfs/` or `core/` directories where the API server is started. The fix would involve adding a call to `os.Remove()` before `net.Listen()` when the address is a Unix socket. Ensure that the removal is done only if the file is a socket (not a regular file) to avoid accidental deletion.