ipfs/kubo

namesys/routing.go imports dht package preventing dht.Quorum() from being used with a custom routing option

Open

#5,957 建立於 2019年1月30日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Go (13,906 star) (2,725 fork)batch import
P3effort/hoursexp/intermediatehelp wantedstatus/ready

描述

If a user is using a custom routing option (like for example, we are using a modified DHT in openbazaar) and they pass in a DhtRecordCount to namesys.Resolve. The routing resolver will call dht.Quorum(int(options.DhtRecordCount)) however, the dht package imported by routing.go is the native dht package and not the one set by the user. The quorum function doesn't apply the option to the custom routing option.

func Quorum(n int) ropts.Option {
	return func(opts *ropts.Options) error {
		if opts.Other == nil {
			opts.Other = make(map[interface{}]interface{}, 1)
		}
		opts.Other[quorumOptionKey{}] = n
		return nil
	}
}

I think the issue using a struct defined inside the package for quorumOptionKey rather than, say, a string.

貢獻者指南

namesys/routing.go imports dht package preventing dht.Quorum() from being used with a custom routing option · ipfs/kubo#5957 | Good First Issue