ipfs/kubo

`ipfs key rm` & `ipfs name publish` error out on empty stdin rather than doing nothing

Open

#4,904 建立於 2018年4月1日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Go (13,906 star) (2,725 fork)batch import
help wantedkind/enhancementtopic/commands

描述

Version information:

go-ipfs version: 0.4.13- Repo version: 6 System version: amd64/linux Golang version: go1.9.4

Type:

Bug

Description:

ipfs key rm and ipfs name publish (and probably other ipfs commands) will, if invoked with no positional arguments, expect input from stdin, presumably so you can pipe in the output of other ipfs commands without needing to faff around with xargs.

The problem is that when input is empty, these commands fail:

$ ipfs name publish </dev/null
ipfs: Reading from /dev/stdin; send Ctrl-d to stop.
Error: invalid 'ipfs ref' path
$ ipfs key rm </dev/null
ipfs: Reading from /dev/stdin; send Ctrl-d to stop.
Error: invalid 'ipfs ref' path

Which is a problem when (as is often the case) the command generating the input may legitimately produce empty input, e.g. ipfs key list | grep remove-me | ipfs key rm.

貢獻者指南

技術棧
go
領域
clibackend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingIPFS CLI basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the stdin reading logic in the `key rm` and `name publish` commands. The issue occurs when stdin is empty; the commands should handle this by doing nothing. Look at the code in the `core/commands/` directory, specifically `key.go` and `name.go` files. The fix should check if stdin has any input before attempting to parse, and if not, exit without error.