ipfs/kubo

Ability to specify known hash when adding

Open

#1,957 建立於 2015年11月10日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Go (13,906 star) (2,725 fork)batch import
help wantedkind/enhancement

描述

ipfs add should have an option that lets the user specify a hash that is known ahead of time. Then when IPFS computes the hash, if they don't match, adding should fail with an error.

This defends against corruption during adding, or lets the user detect that the file was corrupted before it was added at all (for example, a truncated download).

In theory this can also be an optimization, where if the IPFS repo already has a file with the given hash, the file doesn't need to be hashed or added at all.

This depends on the user being able to compute the hash in advance. If the file came from IPFS, then that's not a problem. Otherwise, applications need to be able to compute IPFS hashes for themselves (see #1953).

貢獻者指南

技術棧
go
領域
cli
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with IPFS add commandKnowledge of Go flag parsing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Examine the current implementation of the `ipfs add` command in the Go codebase, specifically how files are added and hashed. Look at the flag parsing to add a new ` known hash` option. Review issue #1953 for context on computing IPFS hashes externally. The implementer should ensure that when the flag is provided, the computed hash is compared to the given value and an error is raised on mismatch.