ipfs/kubo

Lower healthcheck interval

開放

#10,392 建立於 2024年4月9日

 (1 則留言) (0 個反應) (0 位負責人)Go (2,725 個分叉)batch import
P2help wantedkind/enhancement

倉庫指標

星標
 (13,906 顆星)
PR 合併指標
 (平均合併 4天 2小時) (30 天內合併 28 個 PR)

描述

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

Could it be useful to lower the healthcheck interval? From: HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \ To: HEALTHCHECK --interval=5s --timeout=3s --start-period=5s --retries=20 \

Rationale: If you have a service that has IPFS/Kubo as dependency, about 15/20s of boot time get added for every fresh deployment.

This is not an impactful case for production cases, but pre-production & CI cases might see some improvement. In my personal case, I've already seen that gain when using a modified version of Kubo with these settings.
I might be missing something, but I cannot see many drawbacks to have a high interval value, although this could be due to missing some deep internal elements of a DAG resolution at boot time.

PS: if required & desired, I could do the PR myself, although I guess first it's better to agree here about going forward with this change.

Best.

貢獻者指南