ipfs/ipfs-desktop

IPFS Scheme Handler Routes "ipfs://<hash>" to "http://127.0.0.1:8081/<hash>/" while it should route to "http://<hash>.ipfs.localhost:8081/"

Open

#2,728 建立於 2024年1月4日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (5,632 star) (912 fork)batch import
P3exp/beginnergood first issuekind/discussionneed/maintainers-input

描述

  • OS: Windows
  • Version of IPFS Desktop 0.32.0

Describe the bug IPFS Scheme Handler Routes "ipfs://" to "http://127.0.0.1:8081//" while it should route to "http://.ipfs.localhost:8081/"

To Reproduce

  1. Have Scheme handler installed with IPFS desktop
  2. Go to Eg, ipfs://bafybeia3ly2pwdukzwufnof3utydapssmf3eco6sciylew3vd5rg55uxji on Firefox
  3. Accept the dialog
  4. Observe firefox opening page http://127.0.0.1:8081/bafybeia3ly2pwdukzwufnof3utydapssmf3eco6sciylew3vd5rg55uxji/ while it should go to http://bafybeia3ly2pwdukzwufnof3utydapssmf3eco6sciylew3vd5rg55uxji.ipfs.localhost:8081/ instead

貢獻者指南

技術棧
javascript
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with IPFS gateway URL formatBasic knowledge of Electron protocol handlers
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the scheme handler registration in the main process of ipfs desktop. The bug is in the URL transformation from 'ipfs://<hash>' to a gateway URL. Check the code that constructs the final URL, likely in a file handling protocol registration. Review any existing comments or linked issues for context. The expected behavior is to use the subdomain gateway format (http://<hash>.ipfs.localhost:8081/), not the path based format (http://127.0.0.1:8081/<hash>/). Possibly involves modifying the URL construction logic or the gateway configuration.