Bug: Check for updates via menu-bar sub-menu action (macOS) · ipfs/ipfs-desktop#2113

2022-04-28T09:37:04.000Z

- OS: macOS - Version of IPFS Desktop [0.20.0] **Describe the bug** Using latest version of ipfs-desktop, manually selecting to check for updates locks up the UI when the desktop application is not open. **To Reproduce** Steps to reproduce the behavior(macos): 1. Start ipfs-desktop 2. Ensure the menu-bar application is visible, and then close the ipfs-desktop window (the application will still be running, and accessible via the menu-icon) 3. Click the ipfs-desktop menu-bar icon 4. Hover over about 5. Click on 'Check for updates' * The sub-menu may close (I believe this is only on the newest version). If it does, re-open it before the update-checking is done in order to reproduce the bug. 7. Notice that the UI for the menu-bar ipfs menu locks up The ipfs-desktop application will re-open in the dock with a pop-up confirmation indicating that you are on the latest version. **Expected behavior** Checking for updates is a non-blocking background operation. **Screenshots** Action: Locked up UI: Latest version confirmation popup: **Additional context** When I first ran into this bug, the Dock did not display the ifps-desktop icon. So I was unable to close the confirmation popup, and the UI stayed locked up, with the menu-bar menu remaining open and inaccessible. [combined.log](https://github.com/ipfs/ipfs-desktop/files/8581500/combined.log) [error.log](https://github.com/ipfs/ipfs-desktop/files/8581501/error.log)

(2 留言) (0 反應) (0 負責人)JavaScript (5,632 star) (912 fork)batch import

P2area/macoseffort/hoursexp/intermediatehelp wantedkind/bugneed/analysistopic/macos

描述

OS: macOS
Version of IPFS Desktop [0.20.0]

Describe the bug Using latest version of ipfs-desktop, manually selecting to check for updates locks up the UI when the desktop application is not open.

To Reproduce Steps to reproduce the behavior(macos):

Start ipfs-desktop
Ensure the menu-bar application is visible, and then close the ipfs-desktop window (the application will still be running, and accessible via the menu-icon)
Click the ipfs-desktop menu-bar icon
Hover over about
Click on 'Check for updates'
- The sub-menu may close (I believe this is only on the newest version). If it does, re-open it before the update-checking is done in order to reproduce the bug.
Notice that the UI for the menu-bar ipfs menu locks up

The ipfs-desktop application will re-open in the dock with a pop-up confirmation indicating that you are on the latest version.

Expected behavior Checking for updates is a non-blocking background operation.

Screenshots Action:

Locked up UI:

Latest version confirmation popup:

Additional context When I first ran into this bug, the Dock did not display the ifps-desktop icon. So I was unable to close the confirmation popup, and the UI stayed locked up, with the menu-bar menu remaining open and inaccessible.

combined.log error.log

貢獻者指南

技術棧: javascriptnodejselectron
領域: desktopperformance
議題類型: bug
難度: 3
預計時間: half day
活動狀態: stale
清晰度: clear
前置要求: Electron basicsNode.js async patternsIPFS Desktop codebase structure
新手友善度: 60
研究方向: The issue describes a UI freeze when clicking 'Check for updates' from the macOS menu bar while the main window is closed. The fix likely involves making the update check asynchronous. Investigate the menu creation code, likely in src/menu.js, to see how the 'Check for updates' action is handled. Ensure that the update check is performed asynchronously using Electron's autoUpdater module, possibly offloading to a background process or using promises. Also check if the main process is blocked by a synchronous operation. Review the auto update logic in related files to ensure it doesn't freeze the UI.