ipfs/ipfs-companion

"Copy shareable link" is broken for non-ICANN names

Open

#1,060 建立於 2022年2月23日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (1,992 star) (364 fork)batch import
P2area/eth.linkeffort/hoursexp/novicehelp wantedkind/bug

描述

Problem

  1. Open https://dweb.link/ipns/blog.almonit.eth
  2. Try to "Copy shareable link"
  3. Clipboard value is "https://blog.almonit.eth"

The .eth is non-ICANN name, which means it is not safe for sharing with third-party people.

Solution

  • The case above should copy https://dweb.link/ipns/blog.almonit.eth
  • Caveat: we should not special-case .eth, .crypto or any other specific TLD, as user should be able to use their own gateway with custom DoH resolvers that support arbitrary naming systems.
    • :point_right: Companion should ship with a list of ICANN TLDs, and for everything else copy subdomain gateway link

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaScriptbrowser extension basicsDNS/TLD knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is in the ipfs companion browser extension. The 'Copy shareable link' feature copies a simplified IPNS link for non ICANN names like .eth, which should instead use the gateway link. Find the function handling copy link (likely in a file related to IPNS or gateway links). Implement a check against a list of ICANN TLDs; if the domain's TLD is not in that list, copy the full gateway URL. The list can be a static array or imported from an existing library. Ensure the fix does not hardcode specific TLDs to support custom DoH resolvers.