Remove ion-toolbar from being captured in screenshots where its appearance doesn't matter · ionic-team/ionic-framework#30422

(2 留言) (0 反應) (0 負責人)TypeScript (52,503 star) (13,381 fork)batch import

help wantedionfw-internship-2025type: feature request

描述

Currently, any time ion-toolbar changes in appearance, a lot of screenshots have to be updated. Most of them are only being updated because they include ion-toolbar for labeling the test; the change in them doesn’t matter because the test isn’t meant to verify the look of the toolbar.

The following groups of tests should be updated so that the test does not include the toolbar, since it doesn’t make sense to test the toolbar as part of the screenshot test in them:

badge-basic
button
item
list-header
progress-bar
searchbar
toast
toggle

Some of these might have one or two tests where ion-toolbar is used in the component they’re testing, but most of them do not, and all of the components listed here have tests that need to be updated to be refocused so they don’t include the ion-toolbar in the screenshot capture.

貢獻者指南

技術棧: typescripthtmlcssweb components
領域: testingfrontend
議題類型: refactor
難度: 3
預計時間: half day
活動狀態: fresh
清晰度: clear
前置要求: Screenshot testing basicsIonic component knowledge
新手友善度: 75
研究方向: First, examine the referenced PR (#30371) to understand which screenshot files were previously updated. Then, for each test group listed (badge basic, button, item, list header, progress bar, searchbar, toast, toggle), locate the corresponding test files and modify them to exclude the ion toolbar from the screenshot capture. The issue states that most tests include the toolbar only for labeling, so the fix is to remove it from the screenshot region. Review the 2 comments on the issue for any additional guidance or maintainer input. No existing pull requests are linked, so no conflicts.