ionic-team/ionic-framework

feat: Improved types for react useIonModal

Open

#28,680 建立於 2023年12月11日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)TypeScript (13,381 fork)batch import
help wantedpackage: reacttype: feature request

倉庫指標

Star
 (52,503 star)
PR 合併指標
 (平均合併 4天 10小時) (30 天內合併 56 個 PR)

描述

Prerequisites

Describe the Feature Request

useIonModal should type props parameter.

Describe the Use Case

useIonModal currently allows any for component props. This is dangerous and has caused many crashes and unintended behaviors in my experience.

Currently:

export declare function useIonModal(component: ReactComponentOrElement, componentProps?: any): UseIonModalResult;

Describe Preferred Solution

export declare function useIonModal<P>(component: React.ComponentClass<P> | React.FC<P>, componentProps?: P): UseIonModalResult;
export declare function useIonModal(component: React.ReactElement, componentProps?: any): UseIonModalResult;

Describe Alternatives

Leaving as-is

Related Code

No response

Additional Information

If you would accept this change, I would happily make a PR

貢獻者指南