iodide-project/iodide

Binary dragged & dropped files should not be fetched as text by default

開放

#2,456 建立於 2019年11月19日

 (5 則留言) (0 個反應) (0 位負責人)JavaScript (147 個分叉)batch import
good first issuehelp wanted

倉庫指標

星標
 (1,483 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Steps to reproduce:

  • drag & drop a binary file into iodide main page (e.g. an excel file called Furniture_only.xls)

Expected:

%% fetch
blob: file0=Furniture_only.xls

Got:

%% fetch
text: file0=Furniture_only.xls

It is still a pain to do something with the excel file (#2447) but the fact that we're fetching the file as text is yet another roadblock. Perhaps we could sniff the type of the uploaded file and then set this property of the created notebook accordingly? @hamilton / @openjck any thoughts on this?

貢獻者指南