iodide-project/iodide

EXPLORE/REPORT button should just be one instance of one component

Open

#1,673 建立於 2019年3月26日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (1,483 star) (147 fork)batch import
UI appearancebugclient UXgood first issue

描述

the explore/report button is currently actually two components. it should really just be one component that toggles its text+appearance, because it's conceptually just one thing, and not moving it during the transition will also fix a tooltip bug

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React component basicsunderstanding of button's usage
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Locate the two separate components for the explore and report buttons, likely in the components directory. Consolidate them into a single component with a prop to toggle text and appearance. Ensure the tooltip bug (mentioned as caused by moving the button) is fixed by keeping the same DOM element. Review the 3 existing comments for any additional context or requirements.
EXPLORE/REPORT button should just be one instance of one component · iodide-project/iodide#1673 | Good First Issue