internetarchive/openlibrary

Edition's bookcover alt-text should pull author from work

Open

#486 建立於 2017年4月28日

在 GitHub 查看
 (26 留言) (0 反應) (1 負責人)Python (4,626 star) (1,172 fork)batch import
Affects: DataAffects: ServerAffects: UIGood First IssueLead: @cdriniNeeds: ResponsePriority: 3Type: Bug

描述

Correcting a work's author (e.g. https://openlibrary.org/works/OL3531880W/Living_with_Leviathan?b=4&a=3&_compare=Compare&m=diff ) also corrects the Alt-text for the work cover, (e.g. to alt="Cover of: Living with Leviathan by David Brian Smith" ) but fails to correct the Alt-text for the editions below it, instead leaving it untouched (e.g. as alt="Cover of: Living with Leviathan by David Buchanan Smith" ). Might this be why the edition is still found on searches for the old author spelling?

view-source:https://openlibrary.org/books/OL17631357M/Living_with_Leviathan shows the error at lines 349, 357, 371

Proposed fix: Ensure the edition alt-text author name uses the same source data as the rest of the edition interface, which takes the author attached to the work(if it exists)

貢獻者指南

技術棧
python
領域
backendaccessibility
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of PythonFamiliarity with OpenLibrary's data model (works vs editions)
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Focus on the template or view that generates the HTML for edition book covers. Look in the OpenLibrary codebase for where 'alt' attribute of cover images is set, likely in a Python template file (e.g., .html or .pt). The issue notes that the alt text for editions does not update when the work's author is corrected, while the work cover does. Compare how the work cover gets its author data versus the edition cover. Ensure that the edition alt text uses the same author source as the rest of the edition interface, which should be the work's author if available.