import-js/eslint-plugin-import

[no-duplicates] prefer-inline breaks unassigned and top-level type imports

Open

#3,130 建立於 2024年12月23日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedtypescript

描述

"import/no-duplicates": ["error", { "prefer-inline": true }],

Will detect an error in the following typescript code:

import type { X } from "xyz";

import "xyz";

// [...]

It will auto-fix by removing the import "xyz"; statement. This is not the desired behavior. I would expect it to stay as is.

Merry Christmas 🎄

貢獻者指南

技術棧
typescriptjavascript
領域
developer experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of TypeScript import typesBasic knowledge of ESLint rules
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
The issue is about the `no duplicates` rule with `prefer inline` option incorrectly removing a side effect import when a type import from the same module exists. To fix, examine the rule's implementation in `src/rules/no duplicates.ts` (or similar) to understand how it handles `type` imports and side effect imports. The auto fix logic should preserve `import "xyz";` even when `import type { X }` is present. Look at existing tests for `prefer inline` to see how they handle edge cases and add a test case for unassigned imports. The issue reporter provided a clear failing example.