import-js/eslint-plugin-import

🐞: [import/newline-after-import] False positively reports wrong empty line numbers between imports with comments

Open

#2,913 建立於 2023年10月31日

在 GitHub 查看
 (2 留言) (2 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
help wantedimport/export ordering

描述

Something like that:

import './index.scss';

// other imports
import { ErrorBoundary } from 'react-error-boundary';

And my setting is

'import/newline-after-import': [
  'error',
  {
    count: 2,
    exactCount: true,
    considerComments: true
  }
]

It reports like this: image

But this is not the correct behavior, as in the documentation it clearly says:

Enforces having one or more empty lines after the last top-level import statement or require call.

after the last top-level import statement

Note: the exactCount doesn't matter, as I've tried to remove it but it's still causing issue.

Package version: ALL LATEST

貢獻者指南

技術棧
typescriptjavascriptnodejs
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with ESLint
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
The bug is in the 'newline after import' rule, likely in 'src/rules/newline after import.js'. The rule needs to correctly identify the last top level import statement, ignoring comments. Investigate the 'considerComments' option and how it interacts with 'exactCount'. Check if there are existing tests for this scenario and consider adding a new test case.