import-js/eslint-plugin-import

[import/no-duplicates] `{"prefer-inline": true}` does not work

Open

#2,715 建立於 2023年2月12日

在 GitHub 查看
 (14 留言) (13 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedtypescript

描述

version 2.27.5

https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md#inline-type-imports The documentation states that adding {"prefer-inline": true} as shown below will cause errors and autofixes if there are duplicate imports. However, this was not possible in my environment.

{
  "import/no-duplicates": ["error", {"prefer-inline": true}],
}

It should look like the following, but there is no error or anything.

import NextErrorComponent from 'next/error';
import { type ErrorProps } from 'next/error';
// ↓
import NextErrorComponent, { type ErrorProps } from 'next/error';

image

Is this currently being corrected?

貢獻者指南

技術棧
javascripttypescriptnodejs
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic ESLint configurationTypeScript import syntax
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Review the `no duplicates` rule implementation in the eslint plugin import repository, specifically how the `prefer inline` option is handled. Look at the rule's source file (likely `src/rules/no duplicates.js`) and its tests. Check if there are any existing PRs or issues addressing this. The documentation mentions inline type imports, but the actual behavior may not merge duplicate imports as expected. Focus on the logic that merges imports and how the option affects it.