import-js/eslint-plugin-import

import/order relative import sorting order changed in 2.27.0

Open

#2,682 建立於 2023年1月17日

在 GitHub 查看
 (29 留言) (28 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedimport/export ordering

描述

Given the following rule config:

module.exports.rules = {
  'import/order': [
    'error',
    {
      alphabetize: { order: 'asc', caseInsensitive: true },
      groups: ['builtin', 'external', 'internal', ['parent', 'sibling', 'index'], 'object'],
      'newlines-between': 'always',
      warnOnUnassignedImports: true,
    }
  ]
}

In eslint-plugin-import 2.26, sibling imports were sorted after parent imports. In versions 2.27.0 to 2.27.5, siblings are sorted before parents.

Here’s an example of previously valid, but now invalid code:

import { fooz } from '../baz.js'
import { foo } from './bar.js'

貢獻者指南

技術棧
javascriptnodejs
領域
developer experiencetooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of ESLint import/order ruleJavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue reports a regression in the import/order rule where sibling imports are sorted before parent imports since version 2.27.0, contrary to previous behavior. The fix should be localized to the sorting logic for relative imports. Start by examining the 'rules/order.js' file in the eslint plugin import repository, particularly the 'compare' function responsible for sorting. Review the comments in the issue for any proposed solutions or maintainer guidance. The goal is to restore the order so that parent imports come before sibling imports.