import-js/eslint-plugin-import

no-unused-modules "missingExports" returns false positives

Open

#2,102 建立於 2021年5月27日

在 GitHub 查看
 (7 留言) (1 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
`exports` supportbughelp wanted

描述

I'd expect both of these cases to count as exports:

module.exports = {} // Should probably not trigger

export * from './someFile' // Should almost definitely not trigger

貢獻者指南

技術棧
javascriptnodejs
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
eslintnpm module exports
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The bug is in the no unused modules rule's missingExports logic. Examine the rule's source at src/rules/no unused modules.js and its tests in tests/src/rules/no unused modules.js. The issue involves detecting exports from `module.exports = {}` and `export * from './someFile'`. Look at how the rule currently gathers exports and why these cases are missed. Check GitHub for any existing PRs or comments that discuss the detection scope. The fix likely requires modifying the export extraction to include these patterns, ensuring they are considered as exports.