import-js/eslint-plugin-import

`eslint-plugin-import` breaks `eslint` if no `package.json`-file is present

Open

#2,096 建立於 2021年5月24日

在 GitHub 查看
 (27 留言) (0 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
enhancementhelp wanted

描述

If there is no package.json-file in the file to check (or any parent directory), the eslint-run fails due to this piece of code: https://github.com/benmosher/eslint-plugin-import/blob/802ce7d49d912289d590f735bf9bd2d931064863/src/core/packagePath.js#L11-L12

Following error is reported:

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received null
Occurred while linting {filename}.js

貢獻者指南

技術棧
javascriptnodejs
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic Node.js knowledgeUnderstanding of ESLint plugin architectureFile system operations
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is in src/core/packagePath.js at lines 11-12, where path.dirname receives null when no package.json is found. Investigate the function that resolves the package.json path and add a null check or fallback. Review the comments in the issue for proposed solutions, and consider implementing a default or handling the missing file gracefully.