import-js/eslint-plugin-import

Suggestion [`no-named-default`]: add option to allow type imports with multiple imports

Open

#1,869 建立於 2020年8月5日

在 GitHub 查看
 (6 留言) (4 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedtypescript

描述

Typescript's import type cannot be used to import the default export and named exports without using default as:

import type Foo, {Bar} from 'foo'
// A type-only import can specify a default import or named bindings, but not both.

However, these both work but trigger no-duplicates and no-named-default respectively:

import type Foo from 'foo'
import type {Bar} from 'foo'

import type {default as Foo, Bar} from 'foo'

Could there be a new option to no-named-default that allows type imports with multiple imports? For example:

import type {default as Foo} from 'foo' // lint warning
import type {default as Foo, Bar} from 'foo' // fine

貢獻者指南

技術棧
typescriptjavascript
領域
developer experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScriptESLint plugin development basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue requests a new option for the `no named default` rule to allow type imports with multiple imports. Examine the rule's source code in the repository, likely at `src/rules/no named default.js`. Understand how the rule currently processes imports and identify where to add logic for `import type` statements. Update the rule's documentation and add tests for the new option. Look at linked discussions in the issue comments for further clarifications.