import-js/eslint-plugin-import

[BUG] ESLint crashes with `import/no-unused-modules`: Cannot read property 'get' of undefined

Open

#1,716 建立於 2020年4月2日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wanted

描述

Eslint-plugin-import crashes running eslint with Cannot read property 'get' of undefined error.

The error is in lib/rules/no-unused-module.js on line 262:

exportAll.forEach((value, key) => { value.forEach(val => { **const currentExports = exportList.get(val);** const currentExport = currentExports.get(EXPORT_ALL_DECLARATION); currentExport.whereUsed.add(key); }); }); However, if I add condition:

if (currentExports) { const currentExport = currentExports.get(EXPORT_ALL_DECLARATION); currentExport.whereUsed.add(key); } the lint works and I can see all the lint errors .

For now, I disabled the rule in .eslintrc.js file, but would it be possible to create a fix for it, or can I do it as well?

Version: "eslint-plugin-import": "^2.20.0"

貢獻者指南

技術棧
javascriptnodejs
領域
backenddeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic JavaScriptFamiliarity with ESLint plugin rules
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The bug occurs in lib/rules/no unused module.js at line 262 where exportList.get(val) can return undefined. The fix is to add a null check before accessing currentExports. The issue already provides the exact code change. Look at the file to understand the context and ensure the fix doesn't break other cases.