import-js/eslint-plugin-import

[import/newline-after-import] false positive with typescript import = require

Open

#1,654 建立於 2020年2月11日

在 GitHub 查看
 (5 留言) (1 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedtypescript

描述

When using import/newline-after-import with typescript import = require(..) I get a false positive requiring me to put a newline in the middle of the imports.

import foo from "foo";
import bar = require("bar");
import baz from "baz";

Expected results

No errors

Actual results

1:1 error Expected 1 empty line after import statement not followed by another import import/newline-after-import

貢獻者指南

技術棧
javascripttypescriptnodejs
領域
developer experiencetooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ESLint plugin developmentJavaScriptTypeScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the `newline after import` rule in the eslint plugin import source code (likely in `src/rules/newline after import.js`). The rule currently does not recognize TypeScript's `import = require()` as an import statement, causing a false positive. Look for where import statements are identified via AST nodes and add support for `TSImportEqualsDeclaration` (or similar) node type. Check if there are existing tests for TypeScript and add a test case.
[import/newline-after-import] false positive with typescript import = require · import-js/eslint-plugin-import#1654 | Good First Issue