import-js/eslint-plugin-import

False positive: "Multiple default exports" with merged declarations in Typescript

Open

#1,549 建立於 2019年11月30日

在 GitHub 查看
 (0 留言) (5 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedtypescript

描述

In Typescript, a class and an interface with the same name are merged into one type. If I want to export that type as default, I have to export default both the class and the interface.

This is incorrectly flagged with Multiple default exports.

Code:

export default interface Foo {
  a: number
}
export default class Foo {}

Actual:

1:1  error  Multiple default exports  import/export
4:1  error  Multiple default exports  import/export

Expected: No linting error.

Versions:

  • Typescript 3.7.2
  • eslint-plugin-import 2.18.2

貢獻者指南

技術棧
javascripttypescript
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScript knowledgeeslint plugin import architecture
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue is a false positive in the 'export' rule of eslint plugin import. The rule is likely implemented in src/rules/export.js. To fix, need to detect when multiple default exports are actually TypeScript declaration merging of the same name. Look for cases where both exports are of the same identifier and are a class and an interface (or other mergeable types). The plugin may need to use TypeScript's type checker or just check for the pattern where the exported names are identical. Consider referencing TypeScript's declaration merging documentation.