import-js/eslint-plugin-import

Inconsistent import/prefer-default-export with Flow type

Open

#1,164 建立於 2018年8月23日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
bugflowhelp wanted

描述

The following file is generating a warning that default export should be used.

Prefer default export. (import/prefer-default-export)

/* @flow */

export type AnswerState = {
  foo: string
}

export const answer: AnswerState = {
  foo: ''
}

This one however, is not generating any errors or warnings.

/* @flow */

- export type AnswerState = {
+ type AnswerState = {
  foo: string
}

export const answer: AnswerState = {
  foo: ''
}

+ export type { AnswerState }

Originally posted in #484.

貢獻者指南

技術棧
javascript
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ESLint rule developmentFlow type syntax
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Look at the source code of the `prefer default export` rule (likely `src/rules/prefer default export.js`). Understand how it detects named exports versus default exports. The bug is that when a type is defined and exported together with a const, the rule flags it, but when the type is exported separately, it doesn't. The fix might involve checking if the export is a type export and handling that case. Also, review the existing test file for this rule to add a test case for the Flow type scenario.