import-js/eslint-plugin-import

Incorrect import group for npm module and local file with same name in same folder

Open

#1,027 建立於 2018年2月20日

在 GitHub 查看
 (0 留言) (2 反應) (0 負責人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedimport/export ordering

描述

When I have a local file in the same folder with the same name of an npm module, the import/order rule detects the import group incorrectly.

My eslint rule config

'import/order': [
  'error',
  {
    groups: [['builtin', 'external'], 'internal', 'parent', ['sibling', 'index']],
    'newlines-between': 'always',
  },
]

My folder structure:

api/ test,js join-monster.js

join-monster is also a package installed in package.json

test.js

import { merge } from 'lodash';
import joinMonster from 'join-monster';

eslint gives this error

E:\Dropbox\Programming\evercare\api\src\app\api\test.js
  1:1  error  There should be at least one empty line between import groups  import/order

I would expect that it should realize 'join-monster' refers to the npm module and './join-monster' refers to the local file.

貢獻者指南

技術棧
javascriptnodejs
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
familiarity with eslint pluginsknowledge of node module resolutionunderstanding of import/order rule
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue is in the 'import/order' rule's logic for determining import groups. Investigate how the plugin resolves module names, specifically in the context of npm modules vs local files with identical names. Look at the rule's source code (likely in 'rules/order.js') and the module resolution algorithm used. Examine existing tests for similar edge cases. Consider adding a test case with a local file and npm module sharing a name in the same directory.