question: why append RailsPerformance::Extensions to LogSubscriber instead of integrating with Rails notifications directly
#31 建立於 2021年5月3日
倉庫指標
- 星標
- (1,237 顆星)
- PR 合併指標
- (30 天內沒有已合併 PR)
描述
I installed rails_performance on a rails 6.x application and ran a number of page requests. "Recent Requests" included everything as expected. However, the trace info for every request via TraceReport data section was blank.
My rails application uses rails_semantic_logger, which replaces the default ActionView::LogSubscriber and ActiveRecord::LogSubscriber. This prevented rails_performance from tracking the logsubscriber events.
I was able to resolve this by appending the RailsPerformance::Extensions::Db module to the appropriate RailsSemanticLogger LogSubscriber class.
Since ActiveSupport::LogSubscriber is just a logger specific ActiveSupport::Notifications subscriber, why doesn't RailsPerformance just bypass the LogSubscriber altogether and use ActiveSupport::Notifications directly?
If RailsPerformance can use the Notifications directly, would you be comfortable accepting an outside PR?