icsharpcode/SharpZipLib

ZipFile.Create(archivePath) creates 0 bytes archive.

Open

#395 建立於 2019年11月14日

在 GitHub 查看
 (2 留言) (2 反應) (0 負責人)C# (3,502 star) (964 fork)batch import
enhancementhelp wantedzip

描述

Steps to reproduce

  1. Use ZipFile.Create(archivePath) to create an archive.
  2. Close created ZipFile without adding anything to it.

Expected behavior

Created archive have non-zero size (should have "End of central directory record" and be at least 22 bytes according to specification)

Actual behavior

Archive size is 0 bytes, attempt to open it with new ZipFile(archivePath) leads to ZipException "Cannot find central directory"

Version of SharpZipLib

1.1.0 also tried 1.2.0

Obtained from (only keep the relevant lines)

  • Package installed using NuGet

貢獻者指南

技術棧
csharp
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C#ZIP file format knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the ZipFile implementation in SharpZipLib, particularly the Create and Dispose methods. Ensure that when a ZipFile is created and closed without adding any entries, it writes the End of Central Directory record per the ZIP specification. Check the file ZipFile.cs and related tests to understand the current behavior and add a fix to write the EOCD in such cases.