icsharpcode/ILSpy

delegate addition not using +=

Open

#1,755 建立於 2019年10月21日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)C# (25,162 star) (3,645 fork)batch import
C#DecompilerEnhancementHelp Wanted

描述

Ver. tested: d2f72583 Tested with multiple csc compilers.

class C
{
    public delegate void Del_t();
    Del_t dels;
    public void fn()
    {
        dels += cb;
    }
    private void cb() {}
}

Expected: fn to decompile to src form. Actual:

public void fn()
{
    dels = (Del_t)Delegate.Combine(dels, new Del_t(cb));
}

I could have sworn this used to work. Have I been dreaming? Is it a regression?

貢獻者指南

技術棧
csharp
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
C# delegatesILSpy architecturedecompilation concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the decompilation of delegate addition in ILSpy. Check if the issue is a regression by looking at git history for changes in delegate handling. Examine the CSharpDecompiler or related classes for how `+=` is transformed. Consider reaching out in comments for more context.
delegate addition not using += · icsharpcode/ILSpy#1755 | Good First Issue