icesat2py/icepyx

add page size checks for sync/async request mode

開放

#243 建立於 2021年11月9日

 (2 則留言) (0 個反應) (0 位負責人)Python (119 個分叉)auto 404
IS2HW_2022good first issue

倉庫指標

星標
 (256 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

There's still a reference to using a smaller page size in examples/examples/ICESat-2_DAAC_DataAccess_Example.ipynb because it refers to synchronous requests. Note that this notebook indicates that synchronous requests are done by default, but I think this must be outdated. It looks like the request mode is async by default (https://github.com/icesat2py/icepyx/blob/development/icepyx/core/APIformatting.py#L446).

Given that the page size limit is only 100 when the request mode is synchronous, maybe we need another check somewhere that decreases the page size when a user overrides that default and uses synchronous mode?

Originally posted by @trey-stafford in https://github.com/icesat2py/icepyx/issues/239#issuecomment-963612931

貢獻者指南