iced-rs/iced

Superfluous alignment functions

Open

#286 建立於 2020年4月11日

在 GitHub 查看
 (7 留言) (5 反應) (0 負責人)Rust (30,491 star) (1,572 fork)batch import
good first issuehelp wantedlayoutquestion

描述

The current api exposes multiple ways for alignment to be expressed:

  • Container::center_x is equivalent to Container::align_x(Center)
  • HorizonalAlignment, VerticalAlignement, and Align all express the same concept.

These introduce more names and relationships for users to learn about in the api, and I think reducing them would be positive. could we remove them?

貢獻者指南

技術棧
rust
領域
frontenddeveloper experience
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programmingIced API basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Review the alignment related code in the Iced codebase, specifically `Container::center x` and `Container::align x` methods and the alignment enums (`HorizontalAlignment`, `VerticalAlignment`, `Align`). Check existing tests and documentation for these functions. Consult the issue comments (#286) for any maintainer guidance on preferred approach. Implement removal or deprecation with corresponding updates to docs and changelog.