ianyh/Amethyst

Padding settings do not immediately apply

Open

#351 建立於 2015年11月15日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Swift (16,121 star) (516 fork)batch import
bughelp wantedstarter issue

描述

Remaining from the pull request #298.

Amethyst does not trigger changes when changing padding settings, windows need to be resized manually before the new padding is applied or Amethyst needs to be restarted.

The cause of this is both that windows needs to be marked as needing resizes whenever a setting related to padding changes and the leeway for resizes (Amethyst does not consider any window to need a resize if the window padding is smaller than this).

Trello Card

貢獻者指南

技術棧
swift
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
SwiftmacOS window manager conceptsAmethyst codebase structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the changes in pull request #298 to understand the partial fix. Examine the code that handles padding settings, likely in a settings manager or window layout class. Identify where windows are marked as needing resize and add the necessary call when padding settings change. Also check the leeway for resizes as mentioned in the issue.