hyperstack-org/hyperstack

a Native::Object in component params can't be retrieved

Open

#417 建立於 2021年7月16日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (531 star) (43 fork)batch import
buggood first issue

描述

A Native::Object is a BasicObject and it doesn't respond to "tap". It defines method_missing so Native::Object.new.tap returns nil

At hyperstack/ruby/hyper-component/lib/hyperstack/internal/component/props_wrapper.rb:113 .tap returns nil so fetch_from_cache returns nil instead of the Native::Object.

I suggest to rewrite fetch_from_cache without using tap.

貢獻者指南

技術棧
ruby
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
RubyBasicObject
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The issue points to the file `hyperstack/ruby/hyper component/lib/hyperstack/internal/component/props wrapper.rb` at line 113. The current implementation uses `.tap` which fails on `Native::Object` since it is a `BasicObject` that does not respond to `tap`. The fix is to rewrite the `fetch from cache` method without using `tap`, for example by storing the value in a variable and then returning it. Check the comments for any additional context or maintainer input.