hyperstack-org/hyperstack

`Object#loaded?` and `Object#unloaded?` should be defined on the server

Open

#320 建立於 2020年10月19日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (531 star) (43 fork)batch import
enhancementgood first issue

描述

These methods are only useful on the client, but for isomorphic methods they should be also defined on the server. On the server loaded? should always return true, and unloaded? always returns false.

貢獻者指南

技術棧
javascript
領域
full stack
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
95
研究方向
The issue is straightforward: implement Object#loaded? and Object#unloaded? on the server side to always return true and false respectively. The client side implementations likely exist in the Hyperstack Opal codebase. Look in the Ruby source files under lib/ for existing definitions of these methods on Object, and then add server side equivalents, possibly in a separate module or top level definition. The change is localized and requires no additional dependencies.
`Object#loaded?` and `Object#unloaded?` should be defined on the server · hyperstack-org/hyperstack#320 | Good First Issue