hyperstack-org/hyperstack

trying to destroy an item that is not included in the default scope fails

Open

#260 建立於 2019年10月3日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (531 star) (43 fork)batch import
good first issue

描述

If you have a default_scope (other than just all) then some records are not included by a simple query. However you can get you can override the default scope using unscoped. This means you can get the id of records that are not in the default scope.

If you try to destroy one of those records, it doesn't work.

Fix would be on about line 590 of isomorphic_base.rb in the server side destroy_record method. Just change model.find(id) to model.unscoped.find(id)

貢獻者指南

技術棧
rubyrails
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Ruby on RailsActiveRecord
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Look at the `destroy record` method in `isomorphic base.rb` around line 590. The fix is to change `model.find(id)` to `model.unscoped.find(id)`. Ensure the change works with all model scopes and add a test case for destroying records excluded by default scopes.