hound-search/hound

Exceed limit results

Open

#217 建立於 2016年6月20日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (5,470 star) (606 fork)batch import
enhancementhelp wanted

描述

Hi guys, as I can see here https://github.com/etsy/hound/blob/203bd0c7601e28de8c4ae4e922bc0b76938af268/index/index.go#L198 - results are just dropped if they exceed limit (which is constant - 5000).

It is possible to return what was collected so far, instead of just dropping everything. Or, alternatively you can let user set max number of results he wants, of course limited by server's limit too.

For me both are better than what we have now, what do you think?

貢獻者指南

技術棧
go
領域
backendsearch
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
GoRead index.goUnderstand limit logic
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate the current implementation in index/index.go around line 198 where results are dropped if they exceed the constant limit of 5000. Consider implementing either option: (1) modifying the code to return partial results up to the limit, or (2) adding a configurable limit via user input, with a server side cap. Evaluate which approach is more aligned with the project's goals and discuss with maintainers.