hound-search/hound

Add ability to turn of "git clone --depth=1", it's sometimes quite expensive

Open

#207 建立於 2016年5月10日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (5,470 star) (606 fork)batch import
enhancementhelp wanted

描述

This was changed in 2e9ceb9 by @kellegous. See this comment to a CocoaPods issue for why using shallow clones for things like this is a bad idea.

IMO this commit should just be reverted, it makes much more sense to do a full clone and then fetch that with the way the fetch protocol works and how shallow clones can trigger bad edgecases in it, but if not please add some config option to turn this off.

Edit: FWIW this isn't some theoretical thing, I have a very large repo that's running into this edge-case, a "pull" should take 2-3s, but sometimes takes up to 6 minutes from hound (a fresh clone is ~3m) because of the edge cases triggered by the shallow clone.

貢獻者指南

技術棧
javascript
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic JavaScriptfamiliarity with gitunderstanding of git clone
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Examine the commit 2e9ceb9 referenced in the issue to understand the shallow clone implementation. Look at relevant code in the repository, likely in git related modules. Consider whether reverting the commit or adding a configuration option is more appropriate. The issue includes a reference to a CocoaPods issue that discusses downsides of shallow clones. No linked PRs or assignees, so first step is to comment on the issue to confirm maintainer interest and possibly propose a plan.