highlightjs/highlight.js

`noHighlightRe` should win out over `languageDetectRe`

Open

#3,700 建立於 2023年1月25日

在 GitHub 查看
 (12 留言) (0 反應) (0 負責人)JavaScript (22,960 star) (3,497 fork)batch import
enhancementgood first issuehelp welcomeparserversion-12

描述

If a class name matches noHighlightRe it should always be ignored - even if it otherwise looks correct and is also a match of languageDetectRe... this would allow you to use lang-* as your detect match but then also have an exclude list in the noHightlightRe regex.

IE, the block list overrides the allow list. This is an edge case. If no one steps up to work on this before v12 this will auto-close as it's such a small edge case (and also a breaking change).

Is your request related to a specific problem you're having? I am using highlight.js to with "hljs.highlightAll()", and get these warnings. image

The solution you'd prefer / feature you'd like to see added... an option like: excluded-languages: {mermaid, ...} or an option to disable these warnings.

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
familiarity with highlight.jsregex basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Examine the core highlight.js source (likely src/core.js or similar) to understand how noHighlightRe and languageDetectRe are checked. The current logic probably checks languageDetectRe first, then noHighlightRe. A fix would reverse priority so that noHighlightRe wins. Ensure existing tests are updated accordingly. See issue comments for discussion on edge cases and the maintainer's note about potential breaking change.